fix(rn): get login working e2e #1132

moldy530 · 2024-11-06T06:53:40Z

Pull Request Checklist

Did you add new tests and confirm existing tests pass? (yarn test)
Did you update relevant docs? (docs are found in the site folder, and guidelines for updating/adding docs can be found in the contribution guide)
Do your commits follow the Conventional Commits standard?
Does your PR title also follow the Conventional Commits standard?
If you have a breaking change, is it correctly reflected in your commit message? (e.g. feat!: breaking change)
Did you run lint (yarn lint:check) and fix any issues? (yarn lint:write)
Did you follow the contribution guidelines?

PR-Codex overview

This PR focuses on enhancing the NativeTEKStamper integration within the React Native application, improving module exports, and updating dependencies.

Detailed summary

Changed export of NativeTEKStamper from default to named export.
Updated Android module configuration for isTurboModule.
Added dotenv configuration in build.gradle.
Updated package.json with new dependencies.
Enhanced SignerClient class with new methods for authentication.
Improved NativeTEKStamperModule with HPKE decryption support.
Updated various dependencies in yarn.lock for better compatibility.

The following files were skipped due to too many changes: account-kit/rn-signer/example/yarn.lock

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-11-06T06:53:42Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
aa-sdk-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 13, 2024 0:21am
aa-sdk-ui-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 13, 2024 0:21am

moldy530 · 2024-11-06T06:54:02Z

fix(rn): get login working e2e #1132 👈 (View in Graphite)
feat(rn): add stamping logic to android stamper #1131
feat(rn): add bundle injection logic #1130
feat(rn-signer): add key pair generation in android #1129
feat(rn): add alpha react native signer impl #1128 : 1 other dependent PR (#1134 )
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

moldy530 · 2024-11-06T06:54:21Z

...t/rn-signer/android/src/main/java/com/accountkit/reactnativesigner/NativeTEKStamperModule.kt

+        if (Security.getProvider(BouncyCastleProvider.PROVIDER_NAME).javaClass != BouncyCastleProvider::class.java) {
+            Security.removeProvider(BouncyCastleProvider.PROVIDER_NAME)
+        }
+


This was due to the fact that android adds its own bouncy castle implementation that doesn't include EC

moldy530 · 2024-11-06T06:55:09Z

...t/rn-signer/android/src/main/java/com/accountkit/reactnativesigner/NativeTEKStamperModule.kt

                )
                .apply()

            return promise.resolve(true)
        } catch (e: Exception) {
+            Log.e("error", "an error happened", e)


oops, remove this

moldy530 · 2024-11-06T06:56:18Z

account-kit/rn-signer/example/src/App.tsx


 export default function App() {
+  const [publicKey, setPublicKey] = useState<string | null>(null);


⚠️ [eslint] <@typescript-eslint/no-unused-vars> _{reported by reviewdog 🐶}
'publicKey' is assigned a value but never used.

moldy530 · 2024-11-06T06:56:43Z

...t/rn-signer/android/src/main/java/com/accountkit/reactnativesigner/NativeTEKStamperModule.kt

+        }
+
+        return HpkePrivateKey.create(
+            com.google.crypto.tink.hybrid.HpkePublicKey.create(


we use the proto version of the public key elsewhere hence the need for this specific one. I'm going to look into refactoring things so we can use the same interfaces throughout

moldy530 · 2024-11-06T06:57:30Z

...t/rn-signer/android/src/main/java/com/accountkit/reactnativesigner/NativeTEKStamperModule.kt

-        return DatatypeConverter.printHexBinary(outputStream.toByteArray()).uppercase()
+    }
+
+    private fun convertToUncompressedPublicKeyBytes(ephemeralPublicKey: ECPublicKey): ByteArray {


I'm gonna follow up and actually make this a helper that takes in: key: bytes, inputFormat: PointFormatType, outputFormat: PointFormatType to make things a bit cleaner

moldy530 · 2024-11-06T06:58:12Z

account-kit/rn-signer/example/src/signer.ts

This is a super barebones signer implementation that needs to move out of the example and in to the RN src, have this here to test

moldy530 · 2024-11-06T06:59:14Z

Was able to:

generate a link with a bundler
copy the bundle in
complete email auth!

(bundle omitted from image, the user: ... is what we returned from our servers on successful whoami request post login)

dphilipson

Holy cow this is intense. Great work!

dphilipson · 2024-11-06T18:53:29Z

account-kit/rn-signer/example/src/App.tsx

+
+  useEffect(() => {
+    const init = async () => {
+      console.log("init again");


Remember to take this out this log statement and the one below before merging (unless they're intentional).

dphilipson · 2024-11-06T18:54:47Z

account-kit/rn-signer/example/src/App.tsx

+          console.log("publicKey", publicKey);
+          setPublicKey(publicKey);
+        })
+        .catch(console.error);


The async-await is unnecessary. You can either just put this promise-then-catch at the top level of the useEffect callback or keep the async-await and use a try-catch block.

dphilipson · 2024-11-06T18:56:29Z

account-kit/rn-signer/example/src/App.tsx

+              bundle,
+              authenticatingType: "email",
+              connectedEventName: "connectedEmail",
+              orgId: orgId,


(Very nit) No need to repeat orgId here.

dphilipson · 2024-11-06T18:59:22Z

account-kit/rn-signer/example/src/signer.ts

+    });
+  }
+
+  createAccount(params: CreateAccountParams): Promise<SignupResponse> {


I recommend using the override keyword for all the abstract method implementations. It helps with readability and prevents errors if the signature don't match.

dphilipson · 2024-11-06T19:01:28Z

account-kit/rn-signer/src/index.tsx


-export default NativeTEKStamper;
+export { NativeTEKStamper };


Can this be

export { NativeTEKStamper } from "./NativeTEKStamper";

?

iykazrji · 2024-11-13T04:59:19Z

Just going through this! This is glorious @moldy530 ! 🔥🔥🔥

This was referenced Nov 6, 2024

feat(rn): add alpha react native signer impl #1128

Open

feat(rn-signer): add key pair generation in android #1129

Merged

This was referenced Nov 6, 2024

feat(rn): add bundle injection logic #1130

Merged

feat(rn): add stamping logic to android stamper #1131

Merged

moldy530 commented Nov 6, 2024

View reviewed changes

vercel bot had a problem deploying to Preview – aa-sdk-site November 6, 2024 06:57 Failure

moldy530 commented Nov 6, 2024

View reviewed changes

vercel bot had a problem deploying to Preview – aa-sdk-ui-demo November 6, 2024 06:58 Failure

dphilipson approved these changes Nov 6, 2024

View reviewed changes

moldy530 mentioned this pull request Nov 6, 2024

refactor(rn): clean things up so they're more digestable #1134

Merged

7 tasks

moldy530 force-pushed the moldy/rn-stamping branch from 72fae94 to b84f08e Compare November 6, 2024 22:01

moldy530 force-pushed the moldy/rn-login branch from 4dcf02b to 5c58383 Compare November 6, 2024 22:01

vercel bot had a problem deploying to Preview – aa-sdk-site November 6, 2024 22:16 Failure

vercel bot had a problem deploying to Preview – aa-sdk-ui-demo November 6, 2024 22:20 Failure

moldy530 force-pushed the moldy/rn-stamping branch from b84f08e to 4d4d49a Compare November 7, 2024 19:15

moldy530 force-pushed the moldy/rn-login branch from 5c58383 to 9819166 Compare November 7, 2024 19:15

vercel bot had a problem deploying to Preview – aa-sdk-ui-demo November 7, 2024 19:27 Failure

vercel bot had a problem deploying to Preview – aa-sdk-site November 7, 2024 19:27 Failure

moldy530 force-pushed the moldy/rn-stamping branch from 4d4d49a to 4de66d8 Compare November 11, 2024 17:33

moldy530 force-pushed the moldy/rn-login branch from 9819166 to e283195 Compare November 11, 2024 17:34

vercel bot had a problem deploying to Preview – aa-sdk-site November 11, 2024 17:43 Failure

vercel bot had a problem deploying to Preview – aa-sdk-ui-demo November 11, 2024 17:45 Failure

moldy530 force-pushed the moldy/rn-stamping branch from 4de66d8 to 285bed6 Compare November 11, 2024 20:23

moldy530 force-pushed the moldy/rn-login branch from e283195 to 928bec5 Compare November 11, 2024 20:23

vercel bot had a problem deploying to Preview – aa-sdk-site November 11, 2024 20:28 Failure

vercel bot had a problem deploying to Preview – aa-sdk-ui-demo November 11, 2024 20:29 Failure

moldy530 mentioned this pull request Nov 11, 2024

chore: update github actions for rn #1144

Merged

7 tasks

moldy530 marked this pull request as ready for review November 12, 2024 16:22

moldy530 requested review from rthomare, dancoombs, mokok123 and linnall as code owners November 12, 2024 16:22

fix(rn): get login working e2e

ee03d62

moldy530 force-pushed the moldy/rn-stamping branch from 285bed6 to f3c7adb Compare November 13, 2024 00:07

moldy530 force-pushed the moldy/rn-login branch from 928bec5 to ee03d62 Compare November 13, 2024 00:07

vercel bot deployed to Preview – aa-sdk-ui-demo November 13, 2024 00:17 View deployment

vercel bot deployed to Preview – aa-sdk-site November 13, 2024 00:21 View deployment

Base automatically changed from moldy/rn-stamping to moldy/rn-base November 13, 2024 00:27

moldy530 merged commit ee03d62 into moldy/rn-base Nov 13, 2024
3 of 7 checks passed

moldy530 deleted the moldy/rn-login branch November 13, 2024 00:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(rn): get login working e2e #1132

fix(rn): get login working e2e #1132

moldy530 commented Nov 6, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Nov 6, 2024 •

edited

Loading

moldy530 commented Nov 6, 2024 •

edited

Loading

moldy530 Nov 6, 2024

moldy530 Nov 6, 2024

moldy530 Nov 6, 2024

moldy530 Nov 6, 2024

moldy530 Nov 6, 2024

moldy530 Nov 6, 2024

moldy530 commented Nov 6, 2024

dphilipson left a comment

dphilipson Nov 6, 2024

dphilipson Nov 6, 2024

dphilipson Nov 6, 2024

dphilipson Nov 6, 2024

dphilipson Nov 6, 2024

iykazrji commented Nov 13, 2024


		export default function App() {
		const [publicKey, setPublicKey] = useState<string \| null>(null);


		export default NativeTEKStamper;
		export { NativeTEKStamper };

fix(rn): get login working e2e #1132

fix(rn): get login working e2e #1132

Conversation

moldy530 commented Nov 6, 2024 • edited by pr-codex bot Loading

Pull Request Checklist

PR-Codex overview

Detailed summary

vercel bot commented Nov 6, 2024 • edited Loading

moldy530 commented Nov 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moldy530 commented Nov 6, 2024

dphilipson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iykazrji commented Nov 13, 2024

moldy530 commented Nov 6, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Nov 6, 2024 •

edited

Loading

moldy530 commented Nov 6, 2024 •

edited

Loading